Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CUDA 12 #199

Merged
merged 84 commits into from
Jun 1, 2023
Merged

Support CUDA 12 #199

merged 84 commits into from
Jun 1, 2023

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Apr 18, 2023 •
edited by leofang
Loading

Close #139. Close #143.

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #198.

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #198

@conda-forge-webservices conda-forge-webservices bot mentioned this pull request Apr 18, 2023
Closed
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang leofang changed the title MNT: rerender WIP: Support CUDA 12 Apr 18, 2023
@leofang leofang mentioned this pull request Apr 18, 2023
Merged
1 task
@leofang

This comment was marked as resolved.

Sign in to view
@leofang leofang marked this pull request as draft April 18, 2023 02:57
@leofang leofang mentioned this pull request Apr 18, 2023
Closed
5 tasks
@leofang

This comment was marked as outdated.

Sign in to view
@leofang leofang mentioned this pull request Apr 18, 2023
Closed
1 task
jakirkham

This comment was marked as resolved.

Sign in to view

@leofang @jakirkham
add missing nvtx
fe403ef 
Co-authored-by: jakirkham <[email protected]>
@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cupy-feedstock/actions/runs/5136254960.

@jakirkham
Drop conda_build_config.yaml
e42df31 
As this appears to no longer be needed, try dropping it.
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

conda-forge-webservices[bot] and others added 2 commits May 31, 2023 20:21
MNT: Re-rendered with conda-build 3.25.0, conda-smithy 3.23.1, and co…
b761a06 
…nda-forge-pinning 2023.05.31.19.00.54
@jakirkham
Configure using VS2017 on Windows again
15ab482 
Looks like VS2019 still doesn't work here. So readd the
`conda_build_config.yaml` with a configuration to use VS2017 on Windows
again.
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@leofang
Copy link
Member

leofang commented Jun 1, 2023 •
edited
Loading

Thanks, John, let's merge. I noticed one of the ppc64le CIs started hitting error since yesterday. I hope it's just a transient issue. Will monitor & retry on master.

@leofang leofang merged commit b1c034f into conda-forge:main Jun 1, 2023
@leofang
Copy link
Member

leofang commented Jun 1, 2023 •
edited
Loading

btw I deleted the cuda-11 branch since it's no longer needed. With this PR the master recipe has all needed support (cross compiling & CUDA 12).

@leofang
Copy link
Member

leofang commented Jun 1, 2023

@kmaehashi To reduce potential conflicts, would it be OK if I upstream the patch I wrote here? It should be no-op for normal users, and only triggered in a conda-build environment.

@jakirkham
Copy link
Member

Thanks Leo! 🙏

@leofang
Copy link
Member

leofang commented Jun 1, 2023

Travis is misbehaving again... (no output in 10 mins) Will switch back to cross compiling.

@leofang
Copy link
Member

leofang commented Jun 1, 2023

Travis is misbehaving again... (no output in 10 mins) Will switch back to cross compiling.

See #202.

@jakirkham
Copy link
Member

FWIW tried a new Travis build to see if it was a fluke. Though happy to go with cross-compilation

@leofang
Copy link
Member

leofang commented Jun 1, 2023

Oh I already retried twice, sorry I forgot to mention.

@jakirkham
Copy link
Member

Ah ok. Yeah cross-compilation seems like the right solution then

@kmaehashi
Copy link
Member

@kmaehashi To reduce potential conflicts, would it be OK if I upstream the patch I wrote here? It should be no-op for normal users, and only triggered in a conda-build environment.

Yes of course 😄
Thanks so much for the hard work on maintaining the package!

This was referenced Jun 2, 2023
Closed
Closed
Closed
This was referenced Jun 2, 2023
Closed
Merged
@leofang leofang mentioned this pull request Jun 2, 2023
Merged
@leofang
Copy link
Member

leofang commented Jun 2, 2023

Yes of course 😄
Thanks so much for the hard work on maintaining the package!

Sent a PR: cupy/cupy#7603 🙂

jakirkham
jakirkham reviewed Jun 2, 2023
View reviewed changes
recipe/meta.yaml
Comment on lines +141 to +146
# TODO: see https://github.com/conda-forge/cudnn-feedstock/issues/58
- cudnn >=8 # [not ((aarch64 or ppc64le) and cuda_compiler_version == "12.0")]
# TODO: wait for NCCL to catch up
- nccl >=2.8 # [linux and cuda_compiler_version != "12.0"]
- cutensor >=1.4,<2
- cusparselt 0.2.0.* # [(linux64 or win) and cuda_compiler_version == "11.2"]
Copy link
Member

@jakirkham jakirkham Jun 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we can drop some of these selectors now that these packages have been rebuilt

Edit: Filed as issue ( #207 )

This was referenced Jun 2, 2023
Closed
Closed
@leofang leofang mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang left review comments

@jakirkham jakirkham jakirkham left review comments

@asi1024 asi1024 Awaiting requested review from asi1024 asi1024 is a code owner

@emcastillo emcastillo Awaiting requested review from emcastillo emcastillo is a code owner

@kmaehashi kmaehashi Awaiting requested review from kmaehashi kmaehashi is a code owner

@toslunar toslunar Awaiting requested review from toslunar toslunar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please rerender CuPy: Support CUDA 12
4 participants
@conda-forge-admin @leofang @jakirkham @kmaehashi