HashableDict is removed in conda_build 24.7 #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashableDict is deprecated in conda-build 24.5 in favor of deepfreeze, removed in 24.7
it's 10x faster than using deepfreeze
3 tasks
|
Turns out deepfreeze is super expensive (~10x) compared to HashableDict for our purposes. Measuring a rerender of petsc4py: with deepfreeze: 
with HashableDict: 
so keeping HashableDict saves about 1 minute on a 5 minute rerender. |
minrk
changed the title
This was referenced Jun 28, 2024
|
Thank you! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashableDict is deprecated in conda-build 24.5.0 in favor of
frozendict.deepfreeze, removed in 24.7.ref: conda/conda-build#5284
rerender's working for me with this change and conda-build 24.5.1.39_gc49182fe. Rerender time is reduced by about 90% for me with 24.7.x, so I'm looking forward to this release.