Merge pull request #1735 from jaimergp/fix-linter-noarch-selectors

allow operators in noarch selector lint
conda-forge · Aug 24, 2023 · 288dea8 · 288dea8
2 parents 16666ed + d6d357c
commit 288dea8
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 3 deletions.
diff --git a/conda_smithy/lint_recipe.py b/conda_smithy/lint_recipe.py
@@ -965,8 +965,13 @@ def is_selector_line(line, allow_platforms=False):
         return False
     m = sel_pat.match(line)
     if m:
-        if allow_platforms and m.group(3) in ["win", "linux", "osx", "unix"]:
-            return False
+        if allow_platforms:
+            nouns = {
+                w for w in m.group(3).split() if w not in ("not", "and", "or")
+            }
+            if nouns.issubset({"win", "linux", "osx", "unix"}):
+                # the selector only contains (a boolean chain of) platform selectors
+                return False
         else:
             return True
     return False

diff --git a/news/noarch-platforms-lint-selectors-operators.rst b/news/noarch-platforms-lint-selectors-operators.rst
@@ -0,0 +1,23 @@
+**Added:**
+
+* <news item>
+
+**Changed:**
+
+* <news item>
+
+**Deprecated:**
+
+* <news item>
+
+**Removed:**
+
+* <news item>
+
+**Fixed:**
+
+* Allow operators in noarch platform selectors
+
+**Security:**
+
+* <news item>
diff --git a/tests/recipes/noarch_platforms/recipe/meta.yaml b/tests/recipes/noarch_platforms/recipe/meta.yaml
@@ -38,7 +38,7 @@ requirements:
     - tomli >=1.0.0
     - colorama  # [win]
     - __win     # [win]
-    - __unix    # [unix]
+    - __unix    # [not win]
 
   run_constrained:
     # pytest-faulthandler 2 is a dummy package.