-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blas-devel to the packages required to build against blas #2171
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Just to explain why this PR is useful, we were hit again by the missing |
This sounds a bit like blas-devel also should have some run_exports. I'm not sure which ones though. |
This is unnecessary. We've had this design working for years now. Please revert and open an issue in `blas-feedstock. |
Sorry, it is not clear to me why this is unnecessary, can you elaborate more? Thanks!
An issue about what? That |
Yes |
God point, from the name I thought it only dependended on
Done: conda-forge/blas-feedstock#120 . |
Could you send a PR reverting this? |
Done: #2179 . |
PR Checklist:
docs/
orcommunity/
, you have added it to the sidebar in the corresponding_sidebar.json
fileIf you install just
libblas
on Windows (that installs themkl
variant), then for example in CMakefind_package(BLAS REQUIRED)
fails, so it is also necessary to addblas-devel
. On the other hand, it is required to build againstlibblas
aslibblas
has the correctrun_exports
, whileblas-devel
does not have them.