Limit use of numpy 2.0 to imod > 0.17.1 #904
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.I forgot to post the output of
show_diff.py
yesterday. So I re-ran it today, but today the output shows some noise.The hatchling things seem concerning, as that is an upstream dependency, so I wouldn't know how the imod patches would affect their dependency tree.
Let me know what I can do to make the output of show_diff.py look normal again / avoid affecting hatchling's dependency tree.