Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct runtime requirements for snappy <1.2.0 #699

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Correct runtime requirements for snappy <1.2.0 #699

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e74dbcf
Correct runtime requirements for snappy <1.2.0
jjerphan Apr 8, 2024
ad13e8b
Adapt previous patch accordingly
jjerphan Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions recipe/patch_yaml/snappy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,13 @@ then:
- replace_depends:
old: snappy >=1.1.7,<1.1.8.0a0
new: snappy >=1.1.7,<2.0.0.0a0
jjerphan marked this conversation as resolved.
Show resolved Hide resolved
---
# For context, see: https://github.com/conda-forge/snappy-feedstock/issues/35
if:
name: "*"
has_depends: snappy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't catch anything, see the adjusted approach here: #700

timestamp_lt: 1712498454329
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this is the timestamp from linux-64_snappy-1.2.0-hdb0a2a9_0's index.json:

{
  "arch": "x86_64",
  "build": "hdb0a2a9_0",
  "build_number": 0,
  "depends": [
    "libgcc-ng >=12",
    "libstdcxx-ng >=12"
  ],
  "license": "BSD-3-Clause",
  "license_family": "BSD",
  "name": "snappy",
  "platform": "linux",
  "subdir": "linux-64",
  "timestamp": 1712498454329,
  "version": "1.2.0"
}

then:
- tighten_depends:
name: snappy
max_pin: 'x.x'
Loading