Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tighten_depends metis dependency in all packages that depends on metis #527

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 29, 2023

As of 2023/08/29, two version of metis have been packaged on conda-forge:

  • 5.1.0
  • 5.1.1

Both version contain a run_exports: {{ pin_subpackage('metis', max_pin='x.x') }}. However, it emerged that there is an ABI breakage between 5.1.0 and 5.1.1 (see KarypisLab/METIS#71 (comment)), so we need to:

The PR is currently in draft, as I will update it once conda-forge/metis-feedstock#38 is merged.

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment on what the patch is fixing.

@traversaro
Copy link
Contributor Author

Please add a comment on what the patch is fixing.

Done, thanks.

@beckermr
Copy link
Member

Once you are ready to merge this, make it not a draft a pr and we can go ahead!

@traversaro
Copy link
Contributor Author

Once you are ready to merge this, make it not a draft a pr and we can go ahead!

Sure, I am waiting on conda-forge/metis-feedstock#39 and then I will update the timestamp.

@traversaro traversaro force-pushed the patch-5 branch 2 times, most recently from e164210 to 5d76b46 Compare August 30, 2023 13:36
@traversaro
Copy link
Contributor Author

show_diff.py : https://gist.github.com/traversaro/d90db5c42647458d2fbb174ae150f8b1

(in a gist as it is too big for a comment)

@traversaro traversaro marked this pull request as ready for review August 30, 2023 16:38
@traversaro traversaro requested a review from a team as a code owner August 30, 2023 16:38
@traversaro
Copy link
Contributor Author

The PR is ready for review.

@beckermr beckermr added the automerge Merge the PR when CI passes label Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants