Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin snappy at minor level #5730

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Apr 8, 2024

@xhochy xhochy requested a review from a team as a code owner April 8, 2024 15:02
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Member Author

xhochy commented Apr 8, 2024

Will merge once conda-forge/snappy-feedstock#37 is uploaded.

@beckermr
Copy link
Member

beckermr commented Apr 8, 2024

Do we want a formal migration here so that we ensure every feedstock that needs it gets a rerender?

@xhochy xhochy merged commit 5b56205 into conda-forge:main Apr 8, 2024
4 checks passed
@xhochy xhochy deleted the snappy-minor-level branch April 8, 2024 15:38
@xhochy
Copy link
Member Author

xhochy commented Apr 8, 2024

Do we want a formal migration here so that we ensure every feedstock that needs it gets a rerender?

Sorry, this comment only loaded post merge.

I will add a 1.2 migration soon. We already have a repodata patch in place.

@beckermr
Copy link
Member

beckermr commented Apr 8, 2024

Ah hrmmm I am probably confused on this sorry. For some reason I thought a migration from 1 to 1.1 would help feedstocks get the right run export at x.x for the current 1.x series. However, I think unless we mark all old 1.1 versions with the x run export broken and push a migrator, we'll have to live with the possibility that something might get an old version.

@xhochy
Copy link
Member Author

xhochy commented Apr 8, 2024

we'll have to live with the possibility that something might get an old version.

Yes, this is what we did in past cases. I will put in the migrator to 1.2 now and that should fix it. From my understanding, 1.2 is API but not ABI compatible, so we probably move the stack quite quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants