-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 24.3.0 #232
Bump 24.3.0 #232
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.03.18.13.38.52
seems to require conda-build 24.3.0 to not break conda-smithy. |
That'll be released soon-ish, I think we can wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait until conda-forge/conda-forge.github.io#2117 is fixed so that our infrastructure does not break
That makes no sense to me, the relevant conda-build PR isn't even merged yet (aside from the fact that it's only a deprecation, not the removal). |
It's conda 24.3 breaking conda-build 24.1, see conda/conda-build#5221. We should update the existing run_constraint here to |
ref: - conda-forge/conda-forge-repodata-patches-feedstock#685 (comment) Signed-off-by: Marcel Bargull <[email protected]>
Note that the run-constraint turns the upgrade into a bit of a chicken-and-egg problem, in the sense that while the CI here is green, we didn't actually run the conda-smithy downstream test:
AFAIU we'd have to merge conda-forge/conda-build-feedstock#221 first, then the constraints for smithy could be resolved. Or we merge without that downstream test, but I think it'd be safer to do |
@conda-forge-admin, please restart ci |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-feedstock/actions/runs/8419380517. |
@conda-forge-admin, please restart ci |
conda-forge/conda-forge.github.io#2117 is all done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Shall we merge this in today or is there anything else we'd like to check beforehand?
No takers and it's the new day => merging this in! Thanks to @jezdez for the changes and to everyone for looking out for current/future compatibility efforts! |
(This defaulted to "Rebase and merge" for me which did not create a merge commit; no idea why that was the default 🤷.) |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)closes gh-233