-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 2.11.11 and add windows build #18
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.04.10.11.41.14
I guess I wasn't recommending to remove BLAS on Linux and MacOS. This would indeed be a regression and since everything is and has been working fine with BLAS there, I don't see a reason to change it. It is only the linking to BLAS on Windows that is a separate issue, not the linking to BLAS on all platforms. We could consider linking to |
Ah ok! The problem is that --with-blas was removed from all platforms at some point so it was not used at all. That's why I thought you mean a complete removal. |
What about lapack? Is it beneficial to have in addition to let's say cblas? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.04.10.11.41.14
Works now. Including cblas on Win and all other Fortran stuff on unix. |
Great! I couldn't see what you did to get |
Hmm, I don't know why the CI jobs on Azure are not being launched. |
Will lapack require a fortran compiler? |
Apparently not. |
Once you re-render the recipe, conda-forge changes the packages used at build time to the defaults, which are the *netlib version of the blas and lapack packages. Which has the import lib files: |
Everything looks great now, finally! |
@wolfv @h-vetinari Any comments? This should be much faster to review than the previous PR on which you both had a look already. (just to give an estimate, no blame) |
@wolfv @h-vetinari Can we merge this and move on to the other projects in the Cbc stack? These should be much easier. I don't want @jpfeuffer to lose focus on this, as I don't know if I can push it through myself :). |
@jpfeuffer Should we just merge? I'm still working on releases for the rest of the stack, but Osi is done and I will push on the rest if we can get this done. |
On the one hand, I am pretty confident that I addressed the comments from last time. With the new PR also the commit history looks much better. But I think there is nothing that could not be fixed with a smaller follow-up PR. So, I would vote for yes. |
Sorry, haven't had time for this recently. From a quick look this looks good to me, so feel free to go ahead! |
OK, merged. @jpfeuffer, Do you want to make a PR for Osi? It should be smooth sailing form here, since no other Cbc dependency should link directly to BLAS and LAPACK. |
Yay! Yes, I will give it a try! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Closes #16, closes #15, closes #3, closes #1