-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump python requirement for 3.5 #36
Conversation
cloudpickle dropped support for python 2.x as of cloudpipe/cloudpickle#342 (i.e. cloudpickle 1.4.0)
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Sorry, not sure if this is the best way to do this - but the conda package for cloudpickle 1.4.0 incorrectly doesn't specify that it's only python 3.x compatible which causes problems in some python 2.7 environments. I think ideally the existing package for 1.4.0 (noarch/cloudpickle-1.4.0-pyh9f0ad1d_0.tar.bz2) should be removed |
@conda-forge-admin, please rerender |
…da-forge-pinning 2020.04.27.17.45.41
This closes #37. Thank you so much for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Maybe deleting the old package is not required as this new package with the correct metadata targets the same version only with a different build number (1 instead of 0) so maybe the previous package with build number 0 will automatically be discarded by conda on Python 2.
Let's try to merge this to see if this is the case.
Thanks very much @bavardage. |
Build 1 is online but unfortunately conda still picks up the broken build 0 for Python 2.7 environments. |
cloudpickle dropped support for python 2.x as of cloudpipe/cloudpickle#342 (i.e. cloudpickle 1.4.0)
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)