Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump python requirement for 3.5 #36

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Conversation

bavardage
Copy link
Contributor

@bavardage bavardage commented Apr 28, 2020

cloudpickle dropped support for python 2.x as of cloudpipe/cloudpickle#342 (i.e. cloudpickle 1.4.0)

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

cloudpickle dropped support for python 2.x as of cloudpipe/cloudpickle#342 (i.e. cloudpickle 1.4.0)
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@bavardage
Copy link
Contributor Author

Sorry, not sure if this is the best way to do this - but the conda package for cloudpickle 1.4.0 incorrectly doesn't specify that it's only python 3.x compatible which causes problems in some python 2.7 environments.

I think ideally the existing package for 1.4.0 (noarch/cloudpickle-1.4.0-pyh9f0ad1d_0.tar.bz2) should be removed

@bavardage
Copy link
Contributor Author

@conda-forge-admin, please rerender

@pierreglaser
Copy link

pierreglaser commented Apr 28, 2020

This closes #37. Thank you so much for this.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Maybe deleting the old package is not required as this new package with the correct metadata targets the same version only with a different build number (1 instead of 0) so maybe the previous package with build number 0 will automatically be discarded by conda on Python 2.

Let's try to merge this to see if this is the case.

@ogrisel ogrisel merged commit e4529df into conda-forge:master Apr 28, 2020
@ogrisel
Copy link
Contributor

ogrisel commented Apr 28, 2020

Thanks very much @bavardage.

@ogrisel
Copy link
Contributor

ogrisel commented Apr 28, 2020

Build 1 is online but unfortunately conda still picks up the broken build 0 for Python 2.7 environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants