[16.x] Reduce deps for clang on Linux and set sysroot #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
requested review from
JohanMabille,
SylvainCorlay,
chrisburr,
h-vetinari,
inducer,
jakirkham,
katietz,
timsnyder and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
reviewed
Nov 12, 2023
| source ${RECIPE_DIR}/get_cpu_triplet.sh | ||
| CHOST=$(get_triplet $target_platform) | ||
| ln -s "${PREFIX}/bin/clang-${maj_version}" "${PREFIX}/bin/${CHOST}-clang" | ||
| echo "--sysroot ${PREFIX}/${CHOST}/sysroot" >> ${PREFIX}/bin/${CHOST}-clang.cfg |
There was a problem hiding this comment.
Would be good to copy the same comment here as well IMO.
There was a problem hiding this comment.
Nah, that would require keeping them in sync
There was a problem hiding this comment.
Not that hard to avoid that... Fixed in ab4c041 for the forward-port to 17.x
Co-authored-by: h-vetinari <[email protected]>
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
h-vetinari
changed the title
This was referenced Nov 12, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)