Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable LTO on OSX #156

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enable LTO on OSX #156

wants to merge 4 commits into from

Conversation

Skylion007
Copy link

@Skylion007 Skylion007 commented Sep 17, 2021 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closing #155 (for OSX, the flags for LTO with GCC aren't propogated properly it seems or it OOMs), Windows is a bit more complicated since it's only supported when being linked with LLD).

Enable LTO when building for Unix Systems. Will result in significantly higher memory consumption and much longer link and build times, but should build better, faster, smaller binaries.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Skylion007 Skylion007 changed the title Enable LTO on Unix Enable LTO on OSX Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisburr chrisburr Awaiting requested review from chrisburr chrisburr is a code owner

@inducer inducer Awaiting requested review from inducer inducer is a code owner

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

@timsnyder timsnyder Awaiting requested review from timsnyder timsnyder is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skylion007 @conda-forge-linter