Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aarch64 python 3.9 #36

Closed
wants to merge 5 commits into from
Closed

Add support for aarch64 python 3.9 #36

wants to merge 5 commits into from

Conversation

mathbunnyru
Copy link

@mathbunnyru mathbunnyru commented Jul 19, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Fix: #35

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mathbunnyru
Copy link
Author

I copy-pasted aarch64 file for python3.8 and changed the version - is there anything else I should do?

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues, please ping conda-forge/core
for further assistance. You can also try re-rendering locally.

@mathbunnyru
Copy link
Author

I bumped numpy to 1.19 for this python version - is it ok? I've seen it used in other places as well.

@mathbunnyru
Copy link
Author

Seems to work!

@mathbunnyru
Copy link
Author

Travis Ci is misbehaving

@mathbunnyru mathbunnyru reopened this Jul 19, 2021
@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues, please ping conda-forge/core
for further assistance. You can also try re-rendering locally.

@mathbunnyru
Copy link
Author

@jakirkham @msarahan @ocefpaf @qwhelan @wesm may I ask you to take a look please?

Comment on lines +1 to +2
BUILD:
- aarch64-conda_cos7-linux-gnu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being added manually? Did you try re-rendering?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will take a look at what that means and try to re-render.
Sorry, I'm a beginner in conda-forge maintenance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref: #37

@jakirkham jakirkham mentioned this pull request Jul 23, 2021
1 task
@jakirkham
Copy link
Member

PR ( #38 ) should handle this, but there is a lingering question for one of the maintainers

@mathbunnyru
Copy link
Author

Thank you! Hope this will be merged soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing pre-built package linux-aarch64 for python-3.9
3 participants