-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove caps for mamba & conda-build #74
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0e40403
Extend mamba pin
rohan-shah-nearmap 342aa3c
Update build number
rohan-shah-nearmap 831cdda
MNT: Re-rendered with conda-build 3.26.0, conda-smithy 3.24.1, and co…
551beda
Update recipe/meta.yaml
rohan-shah-nearmap 3d69721
Update recipe/meta.yaml
rohan-shah-nearmap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why unpin
conda-build? This change is one of the causes for mamba-org/boa#388.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because that was a long-running effort to unblock many other things that required newer conda-build. The previous cap was there due to explicit incompatibilities, which were removed, hence the cap could be removed.
Now a new incompatibility got introduced with 3.28. It's a separate topic. The only take-away perhaps is to be more defensive on the pins here, and use
<={last_working_conda_build}. In an ideal world that shouldn't be necessary (conda-build should deprecate behaviour changes, rather than just break things), but well...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for clarifying.
Lately my practice has been to pin on major versions (i.e.
conda-build >=3.24,<4) as those are likely to come with breaking changes. However, as we see in this case, there's still the possibility of breaking changes coming in minor version updates, which is unfortunate...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not everyone does versioning according to the server spec...