Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBLAS 0.3.26 & MKL 2024.0; drop MKL on osx #113

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

h-vetinari
Copy link
Member

Pick up recent releases. No news from the side of blis.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari changed the title OpenBLAS 0.3.26 & MKL 2024.0 OpenBLAS 0.3.26 & MKL 2024.0; drop MKL on osx Jan 11, 2024
@h-vetinari
Copy link
Member Author

PTAL @conda-forge/blas

@h-vetinari
Copy link
Member Author

Gentle ping @conda-forge/blas; planning to merge on the weekend if there are no comments.

@h-vetinari h-vetinari merged commit d6ebaf4 into conda-forge:main Jan 23, 2024
14 checks passed
@h-vetinari h-vetinari deleted the impl_bump branch January 23, 2024 03:02
@joshua-cogliati-inl
Copy link

I am not sure if this is the cause, but the following code started throwing an error after we did a conda update that included this version of openblas:

Python 3.10.13 | packaged by conda-forge | (main, Dec 23 2023, 15:36:39) [GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy as np
>>> import scipy.stats
>>> mean = np.zeros(1)
>>> cov=np.eye(1)
>>> mean
array([0.])
>>> cov
array([[1.]])
>>> scipy.stats.multivariate_normal(mean=mean, cov=cov)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/fred/.conda/envs/raven_libraries_new/lib/python3.10/site-packages/scipy/stats/_multivariate.py", line 382, in __call__
    return multivariate_normal_frozen(mean, cov,
  File "/home/fred/.conda/envs/raven_libraries_new/lib/python3.10/site-packages/scipy/stats/_multivariate.py", line 759, in __init__
    self.cov_info = _PSD(self.cov, allow_singular=allow_singular)
  File "/home/fred/.conda/envs/raven_libraries_new/lib/python3.10/site-packages/scipy/stats/_multivariate.py", line 157, in __init__
    s, u = scipy.linalg.eigh(M, lower=lower, check_finite=check_finite)
  File "/home/fred/.conda/envs/raven_libraries_new/lib/python3.10/site-packages/scipy/linalg/_decomp.py", line 547, in eigh
    w, v, *other_args, info = drv(a=a1, **drv_args, **lwork_args)
_flapack.error: (liwork>=max(1,10*n)||liwork==-1) failed for 10th keyword liwork: dsyevr:liwork=1

Code:

import numpy as np
import scipy.stats
mean = np.zeros(1)
cov=np.eye(1)
scipy.stats.multivariate_normal(mean=mean, cov=cov)

@larsoner
Copy link
Contributor

If you update to the latest SciPy build on conda-forge (following conda-forge/scipy-feedstock#268) or downgrade to OpenBLAS 0.3.25 you should be okay I think

@joshua-cogliati-inl
Copy link

If you update to the latest SciPy build on conda-forge (following conda-forge/scipy-feedstock#268) or downgrade to OpenBLAS 0.3.25 you should be okay I think

Thanks. Scipy 1.12 does solve this.

@h-vetinari
Copy link
Member Author

With the merge of conda-forge/conda-forge-repodata-patches-feedstock#642, this should now also be fixed for 1.11 and before

@jakirkham
Copy link
Member

No news from the side of blis.

Asked in issue ( flame/blis#792 ). Sounds like they are still working out some kinks before doing a release

@jakirkham
Copy link
Member

Looks like a new BLIS release should be coming out soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants