-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow 64kb pagesize on aarch64 #1116
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks Ben! 🙏 Could you please add this to azure:
store_build_artifacts: True Then re-render to propagate that change to CI This will cache the packages in CI so that people can try downloading and testing them |
@conda-forge-admin, please rerender |
Thanks Ben! 🙏 Once CI completes it should cache the packages in the CI jobs More details about how to retrieve them in this doc |
Looks like there are now artifacts on CI This covers nearly all jobs except for a couple with known issues ( #1114 ) |
after installing the CI artifacts here on my aarch64 system w/ 64Kb pages - I'm no longer seeing the jemalloc error:
|
@xhochy would you be interested in testing these on macOS ARM to confirm they are working ok there? |
Am on MacBook Pro (16-inch, 2021) with an Apple M1 Pro chip Tried downloading the CI artifact for macOS ARM (named
In this environment tried to $ ipython
Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:41:52) [Clang 15.0.7 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.14.0 -- An enhanced Interactive Python. Type '?' for help.
In [1]: import pyarrow
In [2]: pyarrow
Out[2]: <module 'pyarrow' from '/Users/jkirkham/miniforge/envs/tst_pyarrow/lib/python3.10/site-packages/pyarrow/__init__.py'> |
Thanks for the PR and the testing effort! I'm happy to wait for @xhochy's feedback, but I also think the PR makes sense and having been tested twice is already very good. Also, CI everywhere else is passing, so if you forcepush back to 8cd448c, then I'd be happy to merge this (and backport it to 11.x and 10.x) |
abaab94
to
8cd448c
Compare
thanks @h-vetinari ! I've force pushed back to 8cd448c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if you want to have a look @xhochy; otherwise I'll merge in 24h :)
Closes #1115
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)