Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark patchelf version 0.18.0 linux* broken (pt. 2) #854

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Nov 1, 2023

This version of patchelf regularly corrupts libraries it is patching (on Linux; don't know about macOS). Upstream is aware of the issue, but it is not yet fixed. Also we encountered this before and marked packages broken. However some new ones were published recently. So this marks the new Linux packages broken to avoid further issues due to this patchelf version (have left macOS packages alone).

Fixes conda-forge/patchelf-feedstock#41
xref: #746
xref: NixOS/patchelf#492


Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):

    • Make sure your package is in the right spot (broken/* for adding the
      broken label, not_broken/* for removing the broken label, or token_reset/*
      for token resets)
    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.
  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.

This version of `patchelf` regularly corrupts libraries it is patching.
Upstream is aware of the issue, but it is not yet fixed. Also we
encountered this before and marked packages `broken`. However some new
ones were published recently.  So this marks the new ones broken to
avoid further issues due to this `patchelf` version.
@jakirkham jakirkham requested a review from a team as a code owner November 1, 2023 19:26
@jakirkham
Copy link
Member Author

cc @conda-forge/patchelf

@jakirkham jakirkham changed the title Mark patchelf version 0.18.0 broken (pt. 2) Mark patchelf version 0.18.0 linux* broken (pt. 2) Nov 1, 2023
@jakirkham
Copy link
Member Author

@conda-forge/core , could you please review?

@ocefpaf ocefpaf merged commit 0e38772 into conda-forge:main Nov 1, 2023
1 check passed
@jakirkham jakirkham deleted the mark_patchelf_18_broken_2 branch November 1, 2023 21:48
@jakirkham
Copy link
Member Author

Thanks Filipe! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ELF load command address/offset not properly aligned
2 participants