Fix concretecms/concretecms#12200 #363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"selected" was introduced in c964cdf ; This property doesn't exist in the ajaxData. We may remove this function or should rename it to "treeNodeSelectedIDs", but keep it as it is to avoid unexpected side effects.
Support single select mode correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes concretecms/concretecms#12200
Why this issue didn't happen before version 9?
Because we expanded full tree nodes. Since version 9, we changed to close category nodes initially.
Why this issue didn't happen before #327 ?
Because hidden nodes inside the category nodes weren't selected correctly.
After this PR, those nodes are selected as expected, but I didn't care about single select mode.
What has changed in this PR?
Now, we support the single select mode correctly.
When the select mode is single, we should check and deselect all hidden nodes.
When the select mode is multiple, we should check all hidden nodes and get keys if they are selected.