Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): remove warnings #6335

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

chore(test): remove warnings #6335

wants to merge 4 commits into from

Conversation

liady
Copy link
Contributor

@liady liady commented Sep 7, 2024

Problem:
Today we have a lot of warnings in our Karma output which really clutters it

Fix:
This PR tries to address some of them:

  1. import the default export of package.json instead of import * from
  2. change moduleIds from hashed to deterministic (as Webpack recommends)
  3. import { act } from @testing-library/react instead of react-dom/test-utils

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Copy link
Contributor

github-actions bot commented Sep 7, 2024

Try me

Copy link

relativeci bot commented Sep 7, 2024

#14135 Bundle Size — 62.52MiB (-0.03%).

95ec08f(current) vs 916e8b9 master#14124(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#14135
     Baseline
#14124
Improvement  Initial JS 45.65MiB(-0.04%) 45.67MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 21.56%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4381 4381
No change  Duplicate Modules 520 520
No change  Duplicate Code 31.61% 31.61%
No change  Packages 472 472
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#14135
     Baseline
#14124
Improvement  JS 62.51MiB (-0.03%) 62.53MiB
Improvement  HTML 11.12KiB (-0.32%) 11.16KiB

Bundle analysis reportBranch chore/clear-warnsProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant