Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove defaultMode for mounted volumes #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

corang
Copy link

@corang corang commented Oct 11, 2024

Existing Issue

None currently

Why do we need this PR?

Concourse currently requires to run as root in kubernetes, this boils down to defaultMode being forced on via the helm template, as if you change the uid/gid to anything other than 0:0 (root) it cannot be read.

Changes proposed in this pull request

  • Remove defaultMode from the web deployment to allow Concourse to run in a secure way in kubernetes

Contributor Checklist

  • Variables are documented in the README.md
  • Which branch are you merging into?
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
    • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant