resend shutdownSignal to keep the state:retiring #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Issue
no
Why do we need this PR?
In our productive k8s clusters we observed following problem:
During eviction of the Worker Pod the pre-stop-hook.sh was triggered as expected.
With
fly -t infra workers
we could verify, that the worker state changed to "retiring".But suddenly, the state changed back to
running
, for whatever reason.Thus, the worker, even if it was in pod state
terminating
accepted new incoming concourse jobs.And the worker was running until the pod.spec.terminationGracePeriodSeconds were reached.
Changes proposed in this pull request
retiring
.Contributor Checklist
dev
is for changes related to the next release of Concourse (aka unpublished code onmaster
in concourse/concourse)Reviewer Checklist
master
ordev
)