Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resend shutdownSignal to keep the state:retiring #347

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ewuknadierf
Copy link

Existing Issue

no

Why do we need this PR?

In our productive k8s clusters we observed following problem:
During eviction of the Worker Pod the pre-stop-hook.sh was triggered as expected.
With fly -t infra workers we could verify, that the worker state changed to "retiring".
But suddenly, the state changed back to running, for whatever reason.
Thus, the worker, even if it was in pod state terminating accepted new incoming concourse jobs.
And the worker was running until the pod.spec.terminationGracePeriodSeconds were reached.

Changes proposed in this pull request

  • With this PR, the pre-stop-hook easily sends the shutdownSignal again and again, assuring that the state remain retiring.

Contributor Checklist

  • Which branch are you merging into?
    • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant