Implement maxDepth() on SingleValueFormatter #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for avajs/ava#1433. The react plugin increases value indentation for properties. Combined with `maxDepth` this can lead to property values exceeding the max depth. The `maxDepth()` function is required on `SingleValueFormatter` so the property name is still included in the formatted output.
novemberborn
deleted the
support-single-value-formatters-that-exceed-max-depth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for avajs/ava#1433. The react plugin
increases value indentation for properties. Combined with
maxDepththis can lead to property values exceeding the max depth. The
maxDepth()function is required onSingleValueFormatterso theproperty name is still included in the formatted output.