Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: childCases after adding/removing cases [#186182255] #933

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Oct 10, 2023

[#186182255]

Invalidate/refresh the childCases cache when adding/removing cases to fix formula evaluation of newly added cases.

@kswenson kswenson changed the title fix: childCases after adding/removing cases fix: childCases after adding/removing cases [#186182255] Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (374101e) 82.21% compared to head (3abbfb8) 82.21%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         306      306           
  Lines       12802    12804    +2     
  Branches     3480     3479    -1     
=======================================
+ Hits        10525    10527    +2     
  Misses       2170     2170           
  Partials      107      107           
Flag Coverage Δ
cypress 68.05% <75.00%> (-0.01%) ⬇️
jest 60.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
v3/src/models/data/data-set.ts 97.57% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kswenson kswenson requested a review from pjanik October 11, 2023 00:01
Copy link
Member

@pjanik pjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👍

@kswenson kswenson added the v3 CODAP v3 label Oct 11, 2023
@kswenson kswenson merged commit 543f488 into main Oct 11, 2023
@kswenson kswenson deleted the 186182255-fix-child-cases branch October 11, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 CODAP v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants