-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Group Plotted Value with Univariate Measures (PT-186184994) #923
chore: Group Plotted Value with Univariate Measures (PT-186184994) #923
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
- Coverage 81.21% 81.12% -0.10%
==========================================
Files 306 304 -2
Lines 12782 12703 -79
Branches 3472 3431 -41
==========================================
- Hits 10381 10305 -76
+ Misses 2278 2274 -4
- Partials 123 124 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
71428cc
to
b2275a9
Compare
b2275a9
to
7b4025f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Mostly this looks good. I'm not sure how to handle the strings changes. How was this handled in v2?
@@ -29,7 +31,7 @@ interface ILabelObject { | |||
interface IProps { | |||
cellKey: Record<string, string> | |||
containerId?: string | |||
model: IMeanAdornmentModel | IMedianAdornmentModel | |||
model: IMeanAdornmentModel | IMedianAdornmentModel | IPlottedValueAdornmentModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be able to just use IUnivariateMeasureModel
here rather than having to list them all.
@kswenson In v2 the Plotted Value's text label value is just the numeric value, there is no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed the differences between the Plotted Value and Mean and Median with @bfinzer, which ones were important to keep, which ones might be open to change. One of the changes Bill thought should be made was to have
value=
before the number in the label.
👍 In that case, LGTM
PT Story: https://www.pivotaltracker.com/story/show/186184994
Groups the Plotted Value graph adornment with Mean and Median so that it uses the same base component and model used by the latter.
Note that the following changes to the Plotted Value's appearance and behavior have been approved:
The placement of the Plotted Value's tool tip that appears on hover is at the same level that the Mean and Median's tool tips appear. (This differs from V2 where the Plotted Value's tool tip appears closer to the top of the line.)
The Plotted Value now supports the Show Measure Labels feature that's supported by Mean and Median.
The text that appears before the numeric value in the Plotted Value's tool tip and label will be
value=
(Similar to how the Mean's value is preceded bymean=
, for example).