Fix handling of scenario when attribute name is the same as function name (e.g. "mean(mean)")

[pjanik]

https://www.pivotaltracker.com/story/show/186152786

mean(mean) is a valid formula, but it used to crash in V3. I realized this would be a problem when I added the isNonFunctionSymbolNode helper as part of the previous PR. This is all due to how MathJS parses expressions (function node + separate function name node).

I also renamed canonicalizeExpression to displayToCanonical, so it's the inverse of canonicalToDisplay.

Additionally, I've added quite a few unit tests that also cover the scenario that caused a real-life bug discussed above and in the PT story.

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e8e46cb) 80.71% compared to head (309ef87) 81.22%.

Additional details and impacted files

@@                       Coverage Diff                        @@
##           186144182-canonicalToDisplay     #911      +/-   ##
================================================================
+ Coverage                         80.71%   81.22%   +0.50%     
================================================================
  Files                               305      305              
  Lines                             12587    12587              
  Branches                           3417     3419       +2     
================================================================
+ Hits                              10160    10224      +64     
+ Misses                             2300     2242      -58     
+ Partials                            127      121       -6     

Flag	Coverage Δ
cypress	65.88% <14.28%> (+0.48%)	⬆️
jest	60.90% <50.00%> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
v3/src/models/data/formula-utils.ts	53.23% <75.00%> (+7.91%)	⬆️
v3/src/models/data/formula.ts	75.75% <50.00%> (ø)
v3/src/models/data/formula-manager.ts	17.77% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kswenson]

👍 Looks good