Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lookup functions match user-set title #1702

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Dec 23, 2024

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (0cd0ad0) to head (55c605c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1702      +/-   ##
==========================================
+ Coverage   85.82%   85.91%   +0.08%     
==========================================
  Files         607      607              
  Lines       31162    31162              
  Branches     8063     8600     +537     
==========================================
+ Hits        26746    26772      +26     
+ Misses       4261     4069     -192     
- Partials      155      321     +166     
Flag Coverage Δ
cypress 74.60% <100.00%> (+0.11%) ⬆️
jest 54.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 23, 2024

codap-v3    Run #5634

Run Properties:  status check passed Passed #5634  •  git commit f1cb5d0d17: fix: lookup functions match user-set title (#1702)
Project codap-v3
Branch Review main
Run status status check passed Passed #5634
Run duration 05m 55s
Commit git commit f1cb5d0d17: fix: lookup functions match user-set title (#1702)
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@kswenson kswenson marked this pull request as ready for review December 23, 2024 23:01
Copy link
Contributor

@tealefristoe tealefristoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I'm beginning to think it might be better to scrap having both name and title. But that's probably not a discussion for right before Christmas 😆

@kswenson kswenson merged commit f1cb5d0 into main Dec 23, 2024
24 checks passed
@kswenson kswenson deleted the 188719111-fix-lookup-dataset branch December 23, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants