-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
188651494 pixi js integration #1697
Open
nstclair-cc
wants to merge
19
commits into
main
Choose a base branch
from
188651494-pixiJS-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdinates with pixi js
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
===========================================
+ Coverage 68.07% 85.80% +17.73%
===========================================
Files 607 607
Lines 30810 30823 +13
Branches 8509 8522 +13
===========================================
+ Hits 20975 26449 +5474
+ Misses 9227 4052 -5175
+ Partials 608 322 -286
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #5642
Run Properties:
|
Project |
codap-v3
|
Branch Review |
188651494-pixiJS-integration
|
Run status |
Passed #5642
|
Run duration | 06m 17s |
Commit |
559aff4c00: removed commented line
|
Committer | nstclair-cc |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
53
|
Skipped |
0
|
Passing |
238
|
View all changes introduced in this branch ↗︎ |
- Specified the cypress/e2e/pixi-interaction/**/*.ts pattern for the Cypress step. - Removed: Save Webpack Cache step. - Removed: Upload coverage to Codecov step. - Updated: spec: property to accept the pattern cypress/e2e/smoke/**/*.ts, allowing multiple tests in the smoke folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT-#188651494
Summary
This PR introduces improvements and proof-of-concept tests using PixiJS for graph and map interactions in CODAP v3. We’ve added multiple checks, tools, and tests to enhance our ability to debug and validate graphical behaviors.
New Features
1. Point Selection and Coloring in Graphs and Maps
• Added functionality to validate coloring of points (e.g., selection, legend plots).
• Example proof-of-concept tests now check:
• Colors of points are as expected.
• Colors are valid hex codes (e.g., #4682B4, #E6805B).
2. Counting Points in Graphs and Maps
• Implemented logic to count the number of points in a graph dynamically.
• Validates expected point counts in various scenarios, such as parent-child grouping and attribute selections.
3. Checking Position of Points in Graphs and Maps
• Implemented logic to check the (x, y) position of points in a graph or map.
• Validates expected position in various scenarios, such as undo redo.
4. Debugger Statement
• Introduced a new debugger tool to make it easier to inspect PixiJS point metadata.
• In the browser Console, you can call
pixiPointsMap
to access the array of Pixi points.Tests Added
1. Proof-of-Concept Tests
Included tests for new functionality, such as:
• Point selection validation (with colors).
• Attribute grouping with dynamic point counting.
• Graph updates after selection, hierarchy, and legend interactions.
• Point (x, y) position.
2. PixiJS Checks
Multiple checks added that check:
• Colors of points are accurate and match expectations.
• Graphs update correctly after selections and attribute changes.
• Graph legends and plots dynamically adapt.
• Added logs for pixiPoints, textures, and fill values for better visibility (this is because we don't have visibility with the canvas element; logs help the developer get feedback on the issue when tests fail)
How to Use the Debugger
1. Open the graph or map component.
2. In the Console, call
pixiPointsMap
after enabling the debugger with Key:debug
and Value:pixiPoints
.3. Inspect
pixiPointsMap
to view point metadata (e.g., texture, position).Next Steps
• These changes lay the groundwork for:
• Extending point-coloring logic for additional use cases.
• Enhancing legend interactions for categorical attributes.
Proof of Concept in Action
Here’s an example of what’s now possible:
• Validate graph points are colored correctly.
• Validate graph points are in correct position.
• Verify dynamic updates when selecting attributes or grouping data.
• Debug PixiJS behavior directly in the Console with a single statement.