Update some TODO_V2_IMPORT comments #1694
Merged
+44
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
===========================================
- Coverage 85.86% 68.12% -17.75%
===========================================
Files 607 607
Lines 31012 31012
Branches 8603 8594 -9
===========================================
- Hits 26628 21126 -5502
- Misses 4063 9276 +5213
- Partials 321 610 +289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 05m 58s |
| Commit |
|
| Committer | William Finzer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
36
|
Skipped
|
0
|
Passing
|
220
|
| View all changes introduced in this branch ↗︎ | |
kswenson
approved these changes
Dec 20, 2024
| source?: string | ||
| // TODO_V2_IMPORT data context metadata importDate is not imported | ||
| // TODO_V2_IMPORT_CARRY_OVER G data context metadata importDate is not imported |
There was a problem hiding this comment.
Suggested change
| // TODO_V2_IMPORT_CARRY_OVER G data context metadata importDate is not imported | |
| // TODO_V2_IMPORT_CARRY_OVER data context metadata importDate is not imported |
…ations of what should be done to address the issue. All relate to properties that are present in V2 documents that have not yet been brought into the V3 document model. About 7 stories have been created based on these markers. But the remainder are all in codap-v2-types.ts and can be dealt with in situ. Here is a rough classification. * Properties that were present briefly in V2 documents but are no longer used. These can be ignored in the V3 import. * Properties that are also present in V3 and which refer to implemented features, but the carrying them over during the input process has not yet been brought about. * Properties present in the V3 model which do not yet have an implementation. * Properties not present in V3 but where the feature is present but defined differently. An example of this is `transparency` referring to the opacity of a graph point where this is stored as a separate property in V2 but is an intrinsic part of the `fill` of a point in V3. * Properties referring to a feature present in V2 but which is not yet implemented in V3.
bfinzer
force-pushed
the
update-comments-v2-import-v3
branch
from
b3f4536 to
44b74a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transparencyreferring to the opacity of a graph point where this is stored as a separate property in V2 but is an intrinsic part of thefillof a point in V3.