add dataContextFromURL api #1693
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
- Coverage 85.89% 85.88% -0.01%
==========================================
Files 607 607
Lines 31108 31139 +31
Branches 8643 8052 -591
==========================================
+ Hits 26720 26744 +24
- Misses 4233 4240 +7
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
187738928-api-dataContextFromURL
|
| Run status |
|
| Run duration | 01m 53s |
| Commit |
|
| Committer | Teale Fristoe |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
3
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story: https://www.pivotaltracker.com/story/show/187738928
This PR implements a synchronous version of the
create dataContextFromURLAPI request. It works similarly to v2, where the result is success if there's enough information to attempt to download the data context, even if the actual download fails. In this case, an alert is displayed so the user knows the download failed, but the plugin will not be informed.A separate PR implements an asynchronous version of this API request, which will return a fail response if the download does not succeed: #1699.