Export game view

[scytacki]

This makes isPlugin a serialized field in V3. That is necessary so we can keep track of which WebViews are v2 GameViews and which are v2 WebViews.
The setIsPlugin is marked as withoutUndo so when a plugin is added and it sets up the iframe phone this change of the document state doesn't add an action to the undo stack.

The contextStorage field is added to the DataSet conversion. This was necessary to get a document to load with a plugin that had created a data table. However this document is still broken because it data context collections seem to be reversed and disconnected.

Name handling in GameViews adds more complexity to the already complex name and title handling. GameViews store their name in componentStorage.currentGameName instead of componentStorage.name

[codecov]

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.82%. Comparing base (d705d34) to head (ad52a2d).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
v3/src/components/web-view/web-view-model.ts	77.77%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
- Coverage   85.89%   85.82%   -0.08%     
==========================================
  Files         607      607              
  Lines       31133    31154      +21     
  Branches     8665     8663       -2     
==========================================
- Hits        26743    26739       -4     
- Misses       4068     4091      +23     
- Partials      322      324       +2     

Flag	Coverage Δ
cypress	74.51% <50.00%> (-0.13%)	⬇️
jest	54.05% <91.89%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cypress]

codap-v3    Run #5616

Run Properties:   Passed #5616  •  35b7376c27: Merge pull request #1690 from concord-consortium/188616810-export-gameview

Project	codap-v3
Branch Review	main
Run status	Passed #5616
Run duration	06m 01s
Commit	35b7376c27: Merge pull request #1690 from concord-consortium/188616810-export-gameview
Committer	Kirk Swenson
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	1
Pending	36
Skipped	0
Passing	220
View all changes introduced in this branch ↗︎

[kswenson]

👍 Looks good -- I added a commit which fixed the game view name issue you pointed out.

[kswenson]

Two thoughts occurred to me this morning:

1. Instead of a Boolean isPlugin property, it should be a subType property with value plugin. That way when DG.GuideView is implemented, it can be subType guide. I would leave it undefined for standard web views.
2. The importer for DG.GameView should set the subType property to plugin.

[kswenson]

Two thoughts occurred to me this morning:

1. Instead of a Boolean isPlugin property, it should be a subType property with value plugin. That way when DG.GuideView is implemented, it can be subType guide. I would leave it undefined for standard web views.
2. The importer for DG.GameView should set the subType property to plugin.

After consultation with @scytacki, I added a commit which implemented #1 above. Turns out #2 was already implemented in what @scytacki had done.

[kswenson]

After consultation with @scytacki, I addressed my concerns in a follow-up commit.

[scytacki]

I can't officially approve but it looks good to me.

My only comment is about allowing the v3 WebView to be turned back into a v2 WebView via the subType setter.

[kswenson]

I can't officially approve but it looks good to me.

My only comment is about allowing the v3 WebView to be turned back into a v2 WebView via the subType setter.

Good catch -- I meant to do that. I'll update before merging.