188651851 v3 DI Multiple Y Attributes #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
- Coverage 85.81% 85.78% -0.04%
==========================================
Files 607 607
Lines 30840 30957 +117
Branches 8535 8506 -29
==========================================
+ Hits 26465 26555 +90
- Misses 4057 4080 +23
- Partials 318 322 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tealefristoe
temporarily deployed
to
branches
GitHub Actions
Inactive
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 06m 14s |
| Commit |
|
| Committer | Teale Fristoe |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
36
|
Skipped
|
0
|
Passing
|
220
|
| View all changes introduced in this branch ↗︎ | |
…ltiple y-attributes the `graphDataConfigurationModel` has the desired number of subArrays in its filteredCases array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story: https://www.pivotaltracker.com/story/show/188651851
This PR adds support for multiple y attributes in graph API requests.
yAttributeIDsoryAttirbuteNamesincreate componentrequests.yAttributeIDsandyAttributeNamesare now included in responses toget componentrequests for graphs.yAttributeIDsoryAttributeNamesinupdate componentrequests.Additional bug fixes:
get componentresponses was fixed in this PR. Previously, attribute ids returned were v3 format, that is, strings starting with "ATTR". Now attribute ids returned are in v2 format, just the number part.create component type: tablerequests is now destroyed after a snapshot is taken of it. Previously, this model was not being garbage collected and reactions associated it were continuing to fire.GraphDataConfigurationModelnow overrideshandleDataSetChange, a function called in a reaction defined inDataConfigurationModel. The base function always sets the number offilteredCasesto one, which was preventing dots for multiple y attributes from showing up on freshly created graphs. Now, the proper number offilteredCasesis set for graphs when the dataset changes.