Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

188605717 Add Buffer Space to Bar Charts #1681

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

tealefristoe
Copy link
Contributor

@tealefristoe tealefristoe commented Dec 10, 2024

PT Story: https://www.pivotaltracker.com/story/show/188605717

This PR adds buffer space to FreeDotPlots displaying bars. This makes v3 more closely resemble v2, and in particular makes graphs of a single value look much better.

@tealefristoe tealefristoe marked this pull request as draft December 10, 2024 23:15
@tealefristoe tealefristoe added the v3 CODAP v3 label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (9d2fef2) to head (ca3b49e).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1681    +/-   ##
========================================
  Coverage   85.80%   85.80%            
========================================
  Files         607      607            
  Lines       30810    30810            
  Branches     7921     8447   +526     
========================================
  Hits        26437    26437            
+ Misses       4218     4053   -165     
- Partials      155      320   +165     
Flag Coverage Δ
cypress 75.25% <100.00%> (ø)
jest 53.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 10, 2024

codap-v3    Run #5502

Run Properties:  status check passed Passed #5502  •  git commit be70b89184: Add buffer space to bar charts. (#1681)
Project codap-v3
Branch Review main
Run status status check passed Passed #5502
Run duration 05m 54s
Commit git commit be70b89184: Add buffer space to bar charts. (#1681)
Committer Teale Fristoe
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@tealefristoe tealefristoe marked this pull request as ready for review December 10, 2024 23:34
Copy link
Contributor

@bfinzer bfinzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻LGTM

Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@tealefristoe tealefristoe merged commit be70b89 into main Dec 10, 2024
23 of 24 checks passed
@tealefristoe tealefristoe deleted the 188605717-v3-bar-graph-buffer branch December 10, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants