-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
188605717 Add Buffer Space to Bar Charts #1681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1681 +/- ##
========================================
Coverage 85.80% 85.80%
========================================
Files 607 607
Lines 30810 30810
Branches 7921 8447 +526
========================================
Hits 26437 26437
+ Misses 4218 4053 -165
- Partials 155 320 +165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #5502
Run Properties:
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
Passed #5502
|
Run duration | 05m 54s |
Commit |
be70b89184: Add buffer space to bar charts. (#1681)
|
Committer | Teale Fristoe |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
36
|
Skipped |
0
|
Passing |
220
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
PT Story: https://www.pivotaltracker.com/story/show/188605717
This PR adds buffer space to
FreeDotPlots
displaying bars. This makes v3 more closely resemble v2, and in particular makes graphs of a single value look much better.