Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance attribute value types #1679

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Dec 10, 2024

The substantive change is adding object to IValueType and some related types.
Many of the other changes are path changes that resulted from moving some definitions into attribute-types.ts.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (b3fc392) to head (b51a36a).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1679    +/-   ##
========================================
  Coverage   85.73%   85.73%            
========================================
  Files         607      607            
  Lines       30828    30831     +3     
  Branches     8519     8521     +2     
========================================
+ Hits        26431    26434     +3     
+ Misses       4242     4075   -167     
- Partials      155      322   +167     
Flag Coverage Δ
cypress 75.13% <81.25%> (-0.01%) ⬇️
jest 53.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 10, 2024

codap-v3    Run #5518

Run Properties:  status check passed Passed #5518  •  git commit bad513e239: Increment the build number
Project codap-v3
Branch Review main
Run status status check passed Passed #5518
Run duration 02m 00s
Commit git commit bad513e239: Increment the build number
Committer eireland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

@kswenson kswenson marked this pull request as ready for review December 10, 2024 20:03
@kswenson kswenson requested a review from scytacki December 10, 2024 20:03
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just the one comment about removing the FIXME comments.

The reason for the second FIXME was because TS was complaining when the __id__ was first. It said toCanonical always returned an __id__ so it was unnecessary to set one first. I couldn't figured out why my changes caused this to be a problem so I just moved __id__ to the end. I guess your changes fixed this if TS isn't complaining anymore.

v3/src/v2/codap-v2-document.ts Outdated Show resolved Hide resolved
@kswenson kswenson force-pushed the 188614511-attribute-value-types branch from c844dc2 to b51a36a Compare December 11, 2024 17:54
@kswenson kswenson merged commit 9fd5270 into main Dec 11, 2024
20 of 21 checks passed
@kswenson kswenson deleted the 188614511-attribute-value-types branch December 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants