fix: ruler menu re-renders on undo collection change #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
==========================================
- Coverage 85.69% 85.61% -0.08%
==========================================
Files 601 601
Lines 30550 30551 +1
Branches 7832 8421 +589
==========================================
- Hits 26179 26156 -23
+ Misses 4216 4072 -144
- Partials 155 323 +168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 05m 49s |
| Commit |
|
| Committer | Kirk Swenson |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
36
|
Skipped
|
0
|
Passing
|
220
|
| View all changes introduced in this branch ↗︎ | |
kswenson
force-pushed
the
188548516-fix-ruler-menu-undo
branch
from
dddbf34 to
a867156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PT-188548516]
The PT story mentions a React warning which is a duplicate of another PT story and an MST warning, which is addressed in this PR. The error occurred in the case table/card inspector's ruler menu, which was accessing a stale collection that no longer existed after the undo. The fix is to make the
RulerMenuListanobserver, so that it re-renders when the collections change, flushing any stale collection references.