Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: wrap tile content in dialog modal #1643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lublagg
Copy link
Contributor

@lublagg lublagg commented Nov 21, 2024

No description provided.

@lublagg lublagg changed the title (DO NOT MERGE) SPIKE: wrap tile content in dialog modal SPIKE: wrap tile content in dialog modal Nov 21, 2024
Copy link

cypress bot commented Nov 21, 2024

codap-v3    Run #5310

Run Properties:  status check passed Passed #5310  •  git commit 2e92a76628: spike: wrap tile content in dialog modal
Project codap-v3
Branch Review dialog-wrapper-spike
Run status status check passed Passed #5310
Run duration 05m 56s
Commit git commit 2e92a76628: spike: wrap tile content in dialog modal
Committer lublagg
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 35
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 28 lines in your changes missing coverage. Please review.

Project coverage is 85.61%. Comparing base (3d00012) to head (2e92a76).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/components/codap-component.tsx 48.14% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
+ Coverage   85.60%   85.61%   +0.01%     
==========================================
  Files         601      601              
  Lines       30524    30563      +39     
  Branches     7820     8421     +601     
==========================================
+ Hits        26129    26166      +37     
+ Misses       4240     4077     -163     
- Partials      155      320     +165     
Flag Coverage Δ
cypress 75.16% <46.93%> (+0.04%) ⬆️
jest 52.60% <5.55%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lublagg lublagg marked this pull request as ready for review November 21, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant