-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hierarchical case table updates while dragging points in a graph #1608
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
- Coverage 85.16% 85.12% -0.04%
==========================================
Files 599 600 +1
Lines 30170 30253 +83
Branches 8208 7733 -475
==========================================
+ Hits 25695 25754 +59
- Misses 4148 4344 +196
+ Partials 327 155 -172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #5071
Run Properties:
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
Failed #5071
|
Run duration | 09m 57s |
Commit |
668e369764: fix: case table updating while dragging points in a graph (#1608)
|
Committer | Kirk Swenson |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
1
|
Pending |
48
|
Skipped |
0
|
Passing |
218
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/axis.spec.ts • 1 failed test • Regression Tests
Test | Artifacts | |
---|---|---|
Test graph axes with various attribute types > will add numeric attribute to x axis and categorical attribute to y axis with undo/redo |
Test Replay
Screenshots
|
cypress/e2e/axis.spec.ts • 1 flaky test • Regression Tests
Test | Artifacts | |
---|---|---|
Test graph axes with various attribute types > will add categorical attribute to x axis and numeric attribute to y axis with undo/redo |
Test Replay
Screenshots
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
[PT-188539637]