Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hierarchical case table updates while dragging points in a graph #1608

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Nov 9, 2024

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (3d50df2) to head (ce08464).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/components/case-table/use-rows.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
- Coverage   85.16%   85.12%   -0.04%     
==========================================
  Files         599      600       +1     
  Lines       30170    30253      +83     
  Branches     8208     7733     -475     
==========================================
+ Hits        25695    25754      +59     
- Misses       4148     4344     +196     
+ Partials      327      155     -172     
Flag Coverage Δ
cypress 74.41% <50.00%> (-0.02%) ⬇️
jest 52.59% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 9, 2024

codap-v3    Run #5071

Run Properties:  status check failed Failed #5071  •  git commit 668e369764: fix: case table updating while dragging points in a graph (#1608)
Project codap-v3
Branch Review main
Run status status check failed Failed #5071
Run duration 09m 57s
Commit git commit 668e369764: fix: case table updating while dragging points in a graph (#1608)
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 48
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 218
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/axis.spec.ts • 1 failed test • Regression Tests

View Output

Test Artifacts
Test graph axes with various attribute types > will add numeric attribute to x axis and categorical attribute to y axis with undo/redo Test Replay Screenshots
Flakiness  cypress/e2e/axis.spec.ts • 1 flaky test • Regression Tests

View Output

Test Artifacts
Test graph axes with various attribute types > will add categorical attribute to x axis and numeric attribute to y axis with undo/redo Test Replay Screenshots

@kswenson kswenson changed the title fix: case table updating while dragging points in a graph fix: hierarchical case table updates while dragging points in a graph Nov 9, 2024
@kswenson kswenson marked this pull request as ready for review November 9, 2024 02:00
@kswenson kswenson requested a review from tealefristoe November 9, 2024 02:01
Copy link
Contributor

@tealefristoe tealefristoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kswenson kswenson merged commit 668e369 into main Nov 9, 2024
17 of 20 checks passed
@kswenson kswenson deleted the 188539637-fix-table-performance-mode branch November 9, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants