unify handling of v2 documents #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scytacki
commented
Nov 8, 2024
scytacki
commented
- the codap3 and codap file extensions are now treated the same by the drop code. It is the content of the file that matters
- remove unnecessary createCodapDocument call when a new document was created by the close option which was doing a lot of duplicate work
- importV2Document now just returns the v3 document instance, which allows it to run synchronously
- handleCFMEvent now returns a promise when it does asynchronous things to help with testing
- the codap3 and codap file extensions are now treated the same by the drop code. It is the content of the file that matters - remove unnecessary createCodapDocument call when a new document was created by the close option which was doing a lot of duplicate work - importV2Document now just returns the v3 document instance, which allows it to run synchronously - handleCFMEvent now returns a promise when it does asynchronous things to help with testing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1606 +/- ##
==========================================
+ Coverage 82.22% 83.35% +1.12%
==========================================
Files 594 600 +6
Lines 30026 30238 +212
Branches 8239 8295 +56
==========================================
+ Hits 24690 25204 +514
+ Misses 4973 4683 -290
+ Partials 363 351 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 02m 25s |
| Commit |
|
| Committer | eireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
3
|
| View all changes introduced in this branch ↗︎ | |
kswenson
approved these changes
Nov 10, 2024
|
The one failing cypress test was passing before, and it is listed as one of the flakey tests by the cypress cloud. So I'm going to merge without fixing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.