Fix restored layout of graph of categorical axis #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The categorical axis computes its desired extent based on whether there is a collision of categories if the category text is laid out parallel to the axis. We had been attempting to use the layout's multiscale's scale, which does (eventually) compute a bandwidth, but not in time for the initial render. So we do it a bit more brute force from the axis length and number of categories.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
==========================================
+ Coverage 84.86% 84.98% +0.11%
==========================================
Files 592 592
Lines 29874 29874
Branches 7642 8127 +485
==========================================
+ Hits 25353 25387 +34
+ Misses 4366 4157 -209
- Partials 155 330 +175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 08m 53s |
| Commit |
|
| Committer | William Finzer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
47
|
Skipped
|
0
|
Passing
|
219
|
| View all changes introduced in this branch ↗︎ | |
nstclair-cc
pushed a commit
that referenced
this pull request
Nov 8, 2024
Fix restored layout of graph of categorical axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#188403674] Bug fix: Layout of graph axis not correct on restore