188497515 v3 Plotted Function/Value Formula Editor #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
===========================================
+ Coverage 70.91% 84.73% +13.82%
===========================================
Files 556 591 +35
Lines 24012 29734 +5722
Branches 7274 8168 +894
===========================================
+ Hits 17028 25196 +8168
+ Misses 6976 4205 -2771
- Partials 8 333 +325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 08m 46s |
| Commit |
|
| Committer | Teale Fristoe |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
47
|
Skipped
|
0
|
Passing
|
219
|
| View all changes introduced in this branch ↗︎ | |
kswenson
approved these changes
Oct 30, 2024
| onClose={() => uiState.setEditFormulaAttributeId()} | ||
| titleInput={attribute?.name} | ||
| titleLabel={t("DG.AttrFormView.attrNamePrompt")} | ||
| titlePlaceholder="attribute" |
There was a problem hiding this comment.
Assuming this is user-visible (as placeholders generally are), it should be a localizable string. It's a pre-existing condition, so not necessarily part of this PR, but should be fixed or at least add a TODO comment.
nstclair-cc
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Separate attribute logic from formula editor. * Use EditFormulaModal for plotted function and plotted value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story: https://www.pivotaltracker.com/story/show/188497515
This PR makes the Plotted Function and Plotted Value adornments use the
EditFormulaModalto modify their formulas. In doing so they gain access to autocomplete for variables, functions, and other keywords.EditFormulaModalwas abstracted from theEditAttributeFormulaModal, which is used to modify attribute formulas.EditFormulaModal. Their own special modals of the same name were removed.EditFormulaModalto try to make it better match v2.