-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sorting of hierarchical data sets #1572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1572 +/- ##
===========================================
+ Coverage 70.91% 84.86% +13.94%
===========================================
Files 556 589 +33
Lines 24012 29691 +5679
Branches 7274 7596 +322
===========================================
+ Hits 17028 25196 +8168
+ Misses 6976 4340 -2636
- Partials 8 155 +147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #4820
Run Properties:
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
Passed #4820
|
Run duration | 09m 04s |
Commit |
ca9fa2edf5: fix: item info map after sorting items (#1572)
|
Committer | Kirk Swenson |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
47
|
Skipped |
0
|
Passing |
219
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
[PT-188497004]
Clear/update item indices in
itemInfoMap
after sorting.