Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting of hierarchical data sets #1572

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Oct 29, 2024

[PT-188497004]

Clear/update item indices in itemInfoMap after sorting.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (29012f0) to head (15f9cf2).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1572       +/-   ##
===========================================
+ Coverage   70.91%   84.86%   +13.94%     
===========================================
  Files         556      589       +33     
  Lines       24012    29691     +5679     
  Branches     7274     7596      +322     
===========================================
+ Hits        17028    25196     +8168     
+ Misses       6976     4340     -2636     
- Partials        8      155      +147     
Flag Coverage Δ
cypress 74.56% <100.00%> (+3.64%) ⬆️
jest 52.41% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 29, 2024

codap-v3    Run #4820

Run Properties:  status check passed Passed #4820  •  git commit ca9fa2edf5: fix: item info map after sorting items (#1572)
Project codap-v3
Branch Review main
Run status status check passed Passed #4820
Run duration 09m 04s
Commit git commit ca9fa2edf5: fix: item info map after sorting items (#1572)
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 47
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 219
View all changes introduced in this branch ↗︎

@kswenson kswenson changed the title fix: item info map after sorting items fix: sorting of hierarchical data sets Oct 29, 2024
@kswenson kswenson marked this pull request as ready for review October 29, 2024 20:50
@kswenson kswenson requested a review from tealefristoe October 29, 2024 20:50
Copy link
Contributor

@tealefristoe tealefristoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kswenson kswenson merged commit ca9fa2e into main Oct 29, 2024
20 checks passed
@kswenson kswenson deleted the 188497004-fix-sort-v3 branch October 29, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants