Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187738926 Sort Attribute API Requests #1559

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

tealefristoe
Copy link
Contributor

PT Story: https://www.pivotaltracker.com/story/show/187738926

This PR implements the update dataContext sort API request.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (cdd1b3a) to head (1528b81).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
+ Coverage   84.33%   84.43%   +0.10%     
==========================================
  Files         587      587              
  Lines       29606    29612       +6     
  Branches     8124     8126       +2     
==========================================
+ Hits        24967    25004      +37     
+ Misses       4305     4278      -27     
+ Partials      334      330       -4     
Flag Coverage Δ
cypress 73.92% <10.00%> (+0.10%) ⬆️
jest 52.57% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 23, 2024

codap-v3    Run #4753

Run Properties:  status check passed Passed #4753  •  git commit bc2a44faca: 187738926 Sort Attribute API Requests (#1559)
Project codap-v3
Branch Review main
Run status status check passed Passed #4753
Run duration 01m 20s
Commit git commit bc2a44faca: 187738926 Sort Attribute API Requests (#1559)
Committer Teale Fristoe
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@tealefristoe tealefristoe marked this pull request as ready for review October 23, 2024 23:11
@tealefristoe tealefristoe requested a review from kswenson October 23, 2024 23:11
@tealefristoe tealefristoe marked this pull request as draft October 23, 2024 23:14
@tealefristoe tealefristoe removed the request for review from kswenson October 23, 2024 23:14
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@tealefristoe tealefristoe merged commit bc2a44f into main Oct 25, 2024
16 checks passed
@tealefristoe tealefristoe deleted the 187738926-v3-di-sort branch October 25, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants