Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement logical functions and greatCircleDistance function #1558

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Oct 23, 2024

The following functions are implemented as a part of this story:

  • Logical Functions
    • boolean
    • isBoolean
    • isBoundary
    • isColor
    • isDate
    • isFinite
    • isMissing
    • isNumber
  • Other Functions
    • greatCircleDistance

Copy link

cypress bot commented Oct 23, 2024

codap-v3    Run #4741

Run Properties:  status check passed Passed #4741  •  git commit cdd1b3a41d: feat: implement logical functions and greatCircleDistance function (#1558)
Project codap-v3
Branch Review main
Run status status check passed Passed #4741
Run duration 08m 56s
Commit git commit cdd1b3a41d: feat: implement logical functions and greatCircleDistance function (#1558)
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 45
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 218
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (16f6e70) to head (d3d716f).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
+ Coverage   84.50%   84.53%   +0.02%     
==========================================
  Files         582      583       +1     
  Lines       29435    29480      +45     
  Branches     7547     7560      +13     
==========================================
+ Hits        24875    24920      +45     
  Misses       4404     4404              
  Partials      156      156              
Flag Coverage Δ
cypress 74.03% <18.18%> (-0.11%) ⬇️
jest 52.57% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kswenson kswenson requested a review from tealefristoe October 23, 2024 01:07
@kswenson kswenson marked this pull request as ready for review October 23, 2024 01:07
Copy link
Contributor

@tealefristoe tealefristoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I was a bit surprised at some of the outcomes, especially that booleans are considered to be numbers!

@kswenson
Copy link
Member Author

I was a bit surprised at some of the outcomes, especially that booleans are considered to be numbers!

Technically, convertible to numbers, but yes, I had to double-check some of them myself to make sure v3 was behaving like v2.

@kswenson kswenson merged commit cdd1b3a into main Oct 23, 2024
19 checks passed
@kswenson kswenson deleted the 188416015-logic-functions branch October 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants