-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement logical functions and greatCircleDistance function #1558
Conversation
codap-v3 Run #4741
Run Properties:
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
Passed #4741
|
Run duration | 08m 56s |
Commit |
cdd1b3a41d: feat: implement logical functions and greatCircleDistance function (#1558)
|
Committer | Kirk Swenson |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
45
|
Skipped |
0
|
Passing |
218
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
==========================================
+ Coverage 84.50% 84.53% +0.02%
==========================================
Files 582 583 +1
Lines 29435 29480 +45
Branches 7547 7560 +13
==========================================
+ Hits 24875 24920 +45
Misses 4404 4404
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I was a bit surprised at some of the outcomes, especially that booleans are considered to be numbers!
Technically, convertible to numbers, but yes, I had to double-check some of them myself to make sure v3 was behaving like v2. |
The following functions are implemented as a part of this story: