Hide CFM menu inside of the Activity Player #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interactieApi url param is added to the URL when a activity player embedded share link is copied from the CFM share menu. The CODAP v2 code also checked for older url params `lara` and `launchFromLara`. There are no interactives in the LARA authoring system which use those older params, so support for them is dropped.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1557 +/- ##
=======================================
Coverage 84.50% 84.50%
=======================================
Files 582 582
Lines 29435 29435
Branches 7547 7547
=======================================
Hits 24875 24875
Misses 4404 4404
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 08m 47s |
| Commit |
|
| Committer | Scott Cytacki |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
45
|
Skipped
|
0
|
Passing
|
218
|
| View all changes introduced in this branch ↗︎ | |
scytacki
changed the title
kswenson
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFM menu is hidden when the
interactiveApiURL param is present.The interactiveApi url param is added to the URL when a "Interactive API" share link is copied from the CFM share dialog.
The CODAP v2 code also checked for older url params
laraandlaunchFromLara.codap/apps/dg/core.js
Lines 354 to 359 in 9b54cf1
I checked and there are no URLs in the LARA authoring system which use those older params, so I didn't include support for them in the CODAPv3 code.