fix: undo multiple y [PT-187833677] #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
==========================================
+ Coverage 85.63% 85.72% +0.09%
==========================================
Files 522 522
Lines 25582 25584 +2
Branches 6534 6967 +433
==========================================
+ Hits 21906 21933 +27
+ Misses 3522 3376 -146
- Partials 154 275 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
kswenson
force-pushed
the
187833677-fix-undo-multiple-y
branch
from
3085861 to
95f3251
Compare
kswenson
force-pushed
the
187833677-fix-undo-multiple-y
branch
from
95f3251 to
916463a
Compare
kswenson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PT-187833677]
The crash occurred on undoing the drop of a second (or more) Y attribute because
GraphDataConfigurationModel.filterCasecan get called for the "missing" attribute and crashed when it encountered anundefinedattribute description. Fixing that was straightforward, but revealed an underlying issue that the undo/redo of adding an additional y attribute still didn't work. The fix there was to add a MobX reaction to synchronize thefilteredCasesarray with the attribute configuration. This meant that some bespoke code to manage that synchronization in response to particular events could be eliminated. The new reaction also relies on makingfilteredCasesa MobX shallow-observable array so that additions/removals to/from it can trigger the necessary reaction(s).