-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
182089941 log events #1378
182089941 log events #1378
Conversation
Initial commit of event logging
Adds document metadata to document model properties Log message now has document title as activity property value.
…at information in `properties` prop
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
==========================================
- Coverage 85.74% 82.90% -2.85%
==========================================
Files 522 523 +1
Lines 25582 25672 +90
Branches 6534 6999 +465
==========================================
- Hits 21935 21283 -652
- Misses 3493 4075 +582
- Partials 154 314 +160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ized. Fixes logger jest tests and skips some of them. Adds xhr-mock for jest test. Temporarily removes logger.debug.test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good -- as we discussed I added a couple of commits to tweak things a bit. Also, I feel like there must be more subtleties around the document name/title issue but we can figure that out as we go along.
Adds storing document metadata in the
properties
property of the document model.Adds logger library to send log messages to the log server (currently using concordqa server)
Adds some log messages to some actions for testing (adding a tile, changing a tile title, and closing a tile), though the actual language is still different from V2
Things not included: