Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

182089941 log events #1378

Merged
merged 13 commits into from
Jul 30, 2024
Merged

182089941 log events #1378

merged 13 commits into from
Jul 30, 2024

Conversation

eireland
Copy link
Contributor

Adds storing document metadata in the properties property of the document model.
Adds logger library to send log messages to the log server (currently using concordqa server)
Adds some log messages to some actions for testing (adding a tile, changing a tile title, and closing a tile), though the actual language is still different from V2

Things not included:

  1. Adding run_remote-endpoint to the log message
  2. Adding parameters to the log message

@eireland eireland added the v3 CODAP v3 label Jul 26, 2024
Copy link

cypress bot commented Jul 26, 2024



Test summary

200 0 29 0Flakiness 0


Run details

Project codap-v3
Status Passed
Commit 0dc1a6c
Started Jul 30, 2024 2:53 PM
Ended Jul 30, 2024 3:02 PM
Duration 08:54 💡
OS Linux Ubuntu -
Browser Chrome 126

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (fcdf2bf) to head (805f5cf).
Report is 19 commits behind head on main.

Files Patch % Lines
v3/src/lib/logger.ts 87.27% 7 Missing ⚠️
v3/src/models/app-state.ts 63.63% 3 Missing and 1 partial ⚠️
v3/src/v2/codap-v2-document.ts 84.21% 3 Missing ⚠️
v3/src/components/slider/slider-thumb.tsx 0.00% 1 Missing ⚠️
v3/src/components/slider/use-slider-animation.tsx 66.66% 1 Missing ⚠️
...rc/data-interactive/handlers/collection-handler.ts 0.00% 1 Missing ⚠️
v3/src/data-interactive/handlers/item-handler.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
- Coverage   85.74%   82.90%   -2.85%     
==========================================
  Files         522      523       +1     
  Lines       25582    25672      +90     
  Branches     6534     6999     +465     
==========================================
- Hits        21935    21283     -652     
- Misses       3493     4075     +582     
- Partials      154      314     +160     
Flag Coverage Δ
cypress 69.10% <83.33%> (-3.48%) ⬇️
jest 53.41% <69.50%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eireland added 2 commits July 26, 2024 15:39
…ized.

Fixes logger jest tests and skips some of them.

Adds xhr-mock for jest test.

Temporarily removes logger.debug.test
@eireland eireland marked this pull request as ready for review July 26, 2024 22:57
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good -- as we discussed I added a couple of commits to tweak things a bit. Also, I feel like there must be more subtleties around the document name/title issue but we can figure that out as we go along.

@eireland eireland merged commit 0dc1a6c into main Jul 30, 2024
8 of 11 checks passed
@eireland eireland deleted the 182089941-log-events branch July 30, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 CODAP v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants