Skip to content

Commit

Permalink
[#188640918] Bug fix: When points in dot plot are dragged, mean isn't…
Browse files Browse the repository at this point in the history
… updating

* This bug first appeared in build 1949, in October, 2024. Some update machinery in data-configuration-model.ts was removed around then so `GraphContentModel:updateAdornments` was no longer being called when case values are changed. The only thing that needed to be fixed was to increment the `DataConfigurationModel`'s `casesChangeCount` in `handleSetCaseValues`. Doing so restored the previous behavior with no apparent added cost.
  • Loading branch information
bfinzer committed Dec 3, 2024
1 parent f58123d commit ba73504
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,7 @@ export const DataConfigurationModel = types
const idSet = new Set(cases.changed)
const changedCases = affectedCases.filter(aCase => idSet.has(aCase.__id__))
self.handlers.forEach(handler => handler({name: "setCaseValues", args: [changedCases]}))
++self.casesChangeCount
}
// Changes to case values require that existing cached categorySets be wiped.
// But if we know the ids of the attributes involved, we can determine whether
Expand Down

0 comments on commit ba73504

Please sign in to comment.