Skip to content

Commit

Permalink
Final PR review feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
tealefristoe committed Oct 23, 2024
1 parent 99cd092 commit ab11b26
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion v3/src/components/web-view/web-view-constants.ts

This file was deleted.

1 change: 1 addition & 0 deletions v3/src/components/web-view/web-view-defs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ export const kV2GameType = "game"
export const kV2GuideViewType = "guideView"
export const kV2WebViewType = "webView"
export const kWebViewTileClass = "codap-web-view"
export const kWebViewBodyClass = "codap-web-view-body"
2 changes: 1 addition & 1 deletion v3/src/components/web-view/web-view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React, { useRef } from "react"
import { t } from "../../utilities/translation/translate"
import { ITileBaseProps } from "../tiles/tile-base-props"
import { useDataInteractiveController } from "./use-data-interactive-controller"
import { kWebViewBodyClass } from "./web-view-constants"
import { kWebViewBodyClass } from "./web-view-defs"
import { WebViewDropOverlay } from "./web-view-drop-overlay"
import { isWebViewModel } from "./web-view-model"

Expand Down
2 changes: 1 addition & 1 deletion v3/src/data-interactive/handlers/attribute-handler.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { kContainerClass } from "../../components/container/container-constants"
import { kPluginAttributeDragId } from "../../components/drag-drop/drag-drop-constants"
import { kWebViewBodyClass } from "../../components/web-view/web-view-constants"
import { kWebViewBodyClass } from "../../components/web-view/web-view-defs"
import { appState } from "../../models/app-state"
import { IAttribute } from "../../models/data/attribute"
import { createAttributesNotification, updateAttributesNotification } from "../../models/data/data-set-notifications"
Expand Down
1 change: 0 additions & 1 deletion v3/src/hooks/use-drag-drop.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {
Active, DataRef, DragEndEvent, Modifier, useDndMonitor,
useDraggable, UseDraggableArguments, useDroppable, UseDroppableArguments
} from "@dnd-kit/core"
import { kIndexColumnKey } from "../components/case-tile-common/case-tile-types"
import { kTitleBarHeight } from "../components/constants"
import { IDataSet } from "../models/data/data-set"
import { useInstanceIdContext } from "./use-instance-id-context"
Expand Down

0 comments on commit ab11b26

Please sign in to comment.