Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for checkboxes #7

Closed
1 of 2 tasks
karllhughes opened this issue Jul 16, 2017 · 3 comments
Closed
1 of 2 tasks

Support for checkboxes #7

karllhughes opened this issue Jul 16, 2017 · 3 comments

Comments

@karllhughes
Copy link

I know these aren't standard in all flavors of markdown, but any interest in supporting Github's style of checkboxes in this package?

This example:

- [ ] An unchecked checkbox
- [x] A checked checkbox

Would render as it does on Github:

  • An unchecked checkbox
  • A checked checkbox
@karllhughes
Copy link
Author

Didn't really notice, but this is in the works (possibly) for chjj/marked, so I'm guessing when it's merged in there it will also work in this package, yes?

@vknabel
Copy link
Contributor

vknabel commented Jul 17, 2017

@karllhughes Yes. If markedjs/marked#587 will be merged, markdown-to-html-pipe will support checkboxes.

@vknabel
Copy link
Contributor

vknabel commented Jul 20, 2017

@karllhughes With [email protected] chjj/marked is now a peer dependency.
That way you can temporarily replace chjj/marked with jhollingworth/marked. Once the PR will be merged and released, even versions like 0.4.0 or 1.0.0 wouldn't require an update to markdown-to-html-pipe.

If there are any other issues or suggestions, feel free to ask.

@vknabel vknabel closed this as completed Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants