master keycloak:449 add keycloak as IdP for doil managed ILIAS Instances #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
daniwe4
commented
Nov 13, 2024
daniwe4
commented
- add keycloak commands (down/login/restart/up)
- add saml states (enable-saml/disable-saml)
- add keycloak state
- add keycloak template
- update CHANGELOG
- update README
- add an update script
- tested so far on my local host
daniwe4
force-pushed
the
master_449
branch
3 times, most recently
from
67486a8 to
bb6473c
Compare
tbongers-cat
requested changes
Nov 13, 2024
tbongers-cat
approved these changes
Nov 14, 2024
klees
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Hallo @daniwe4,
folgende Dinge sind mir generell aufgefallen:
- Im Keycloak-Container scheinen viele Dinge als root laufen zu sollen. Wollen wir das wirklich?
- Wir können für SimpleSAML in ILIAS einfach die ILIAS-DB mit nutzen. Beschreibung ist hier. Das erspart und sqlite (ein moving part weniger...) und außerdem kann dann auch ohne viel Hussle mit dem Adminer in die Tabellen von SimpleSAML geschaut werden.
Ansonsten: OASOM!!
Beste Grüße!
setup/stack/states/enable-saml/saml/addInstanceToKeycloak.sh.j2
Outdated
Show resolved
Hide resolved
daniwe4
force-pushed
the
master_449
branch
5 times, most recently
from
76d54cb to
2a4e2c8
Compare
klees
approved these changes
Nov 25, 2024
* add keycloak commands (down/login/restart/up) * add saml states (enable-saml/disable-saml) * add keycloak state * add keycloak template * update CHANGELOG * update README * add an update script * tested so far on my local host * adjust tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.